Fixed issue where firebase init hosting re-prompts for source #8617

aalej · 2025-05-16T17:17:11Z

Description

From what I can tell, the previous behavior of promptOnce and prompt was that, once a question has an answer, we no longer prompt for that question

--- promptOnce

firebase-tools/src/prompt.ts

Lines 108 to 113 in 8cc734b

    
           export async function promptOnce<A>(question: Question, options: Options = {}): Promise<A> { 
        
             // Need to replace any .'s in the question name - otherwise, Inquirer puts the answer 
        
             // in a nested object like so: `"a.b.c" => {a: {b: {c: "my-answer"}}}` 
        
             question.name = question.name?.replace(/\./g, "/") || "question"; 
        
             await prompt(options, [question]); 
        
             return options[question.name];

--- prompt

firebase-tools/src/prompt.ts

Lines 47 to 70 in 8cc734b

    
           export async function prompt( 
        
             options: Options, 
        
             // NB: If Observables are to be added here, the for loop below will need to 
        
             // be adjusted as well. 
        
             questions: ReadonlyArray<inquirer.DistinctQuestion>, 
        
           ): Promise<any> { 
        
             const prompts = []; 
        
             // For each of our questions, if Options already has an answer, 
        
             // we go ahead and _skip_ that question. 
        
             for (const question of questions) { 
        
               if (question.name && options[question.name] === undefined) { 
        
                 prompts.push(question); 
        
               } 
        
             } 
        
             if (prompts.length && options.nonInteractive) { 
        
               const missingOptions = Array.from(new Set(prompts.map((p) => p.name))).join(", "); 
        
               throw new FirebaseError( 
        
                 `Missing required options (${missingOptions}) while running in non-interactive mode`, 
        
                 { 
        
                   children: prompts, 
        
                 }, 
        
               ); 
        
             }

Scenarios Tested

Verified that the prompts behave the same as the old versions (14.2.2)

14.2.2 behavior

$ firebase --version
14.2.2
$ firebase init hosting --project PROJECT_ID

     ######## #### ########  ######## ########     ###     ######  ########
     ##        ##  ##     ## ##       ##     ##  ##   ##  ##       ##
     ######    ##  ########  ######   ########  #########  ######  ######
     ##        ##  ##    ##  ##       ##     ## ##     ##       ## ##
     ##       #### ##     ## ######## ########  ##     ##  ######  ########

You're about to initialize a Firebase project in this directory:

  /PATH/orbital-osiris

Before we get started, keep in mind:

  * You are currently outside your home directory


=== Project Setup

First, let's associate this project directory with a Firebase project.
You can create multiple project aliases by running firebase use --add, 
but for now we'll just set up a default project.

i  Using project PROJECT_ID (PROJECT_NAME)

=== Hosting Setup
? Detected an existing Astro codebase in the current directory, should we use this? Yes
? In which region would you like to host server-side content, if applicable? us-central1 (Iowa)
? Set up automatic builds and deploys with GitHub? No

i  Writing configuration info to firebase.json...
i  Writing project information to .firebaserc...

✔  Firebase initialization complete!

branch behavior

$ firebase --version
14.4.0
$ firebase init hosting --project PROJECT_ID

     ######## #### ########  ######## ########     ###     ######  ########
     ##        ##  ##     ## ##       ##     ##  ##   ##  ##       ##
     ######    ##  ########  ######   ########  #########  ######  ######
     ##        ##  ##    ##  ##       ##     ## ##     ##       ## ##
     ##       #### ##     ## ######## ########  ##     ##  ######  ########

You're about to initialize a Firebase project in this directory:

  /PATH/8587


=== Project Setup

First, let's associate this project directory with a Firebase project.
You can create multiple project aliases by running firebase use --add, 
but for now we'll just set up a default project.

i  Using project PROJECT_ID (PROJECT_NAME)

=== Hosting Setup
✔ Detected an existing Astro codebase in the current directory, should we use this? Yes
✔ In which region would you like to host server-side content, if applicable? us-central1 (Iowa)
✔ Set up automatic builds and deploys with GitHub? No

i  Writing configuration info to firebase.json...
i  Writing project information to .firebaserc...

✔  Firebase initialization complete!

Sample Commands

jamesdaniels · 2025-05-16T17:20:50Z

src/init/features/hosting/index.ts

-        default: true,
-      });
+      setup.hosting.useDiscoveredFramework =
+        setup.hosting.useDiscoveredFramework ||


You could simplify with ||= here for same effect but you really should be using ?? or ??= here since we want false to be a cachable value

Same feedback for other changed lines

Thanks for the feedback! Will update

Fixed issue where firebase init hosting re-prompts for source

9350a6e

github-project-automation bot added this to [Cloud] Extensions + Functions May 16, 2025

aalej requested review from joehan and jamesdaniels May 16, 2025 17:17

jamesdaniels requested changes May 16, 2025

View reviewed changes

github-project-automation bot moved this to Changes Requested [PR] in [Cloud] Extensions + Functions May 16, 2025

leoortizz mentioned this pull request May 16, 2025

prevent discovery to run twice [WIP] #8619

Closed

aalej added 2 commits May 17, 2025 01:40

Simplify and correct condition for determining when to prompt

0b20a69

Merge branch 'master' into aalej-wfe-init-hosting

8fb5db4

aalej requested a review from jamesdaniels May 16, 2025 17:42

jamesdaniels approved these changes May 19, 2025

View reviewed changes

github-project-automation bot moved this from Changes Requested [PR] to Approved [PR] in [Cloud] Extensions + Functions May 19, 2025

Merge branch 'master' into aalej-wfe-init-hosting

52ccca6

joehan approved these changes May 22, 2025

View reviewed changes

joehan enabled auto-merge (squash) May 22, 2025 18:26

joehan merged commit a5a619f into master May 22, 2025
47 of 50 checks passed

joehan deleted the aalej-wfe-init-hosting branch May 22, 2025 18:37

github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed issue where firebase init hosting re-prompts for source #8617

Fixed issue where firebase init hosting re-prompts for source #8617

aalej commented May 16, 2025 •

edited

Loading

jamesdaniels May 16, 2025

jamesdaniels May 16, 2025

aalej May 16, 2025

	export async function promptOnce<A>(question: Question, options: Options = {}): Promise<A> {
	// Need to replace any .'s in the question name - otherwise, Inquirer puts the answer
	// in a nested object like so: `"a.b.c" => {a: {b: {c: "my-answer"}}}`
	question.name = question.name?.replace(/\./g, "/") \|\| "question";
	await prompt(options, [question]);
	return options[question.name];

	export async function prompt(
	options: Options,
	// NB: If Observables are to be added here, the for loop below will need to
	// be adjusted as well.
	questions: ReadonlyArray<inquirer.DistinctQuestion>,
	): Promise<any> {
	const prompts = [];
	// For each of our questions, if Options already has an answer,
	// we go ahead and _skip_ that question.
	for (const question of questions) {
	if (question.name && options[question.name] === undefined) {
	prompts.push(question);
	}
	}

	if (prompts.length && options.nonInteractive) {
	const missingOptions = Array.from(new Set(prompts.map((p) => p.name))).join(", ");
	throw new FirebaseError(
	`Missing required options (${missingOptions}) while running in non-interactive mode`,
	{
	children: prompts,
	},
	);
	}

Fixed issue where firebase init hosting re-prompts for source #8617

Fixed issue where firebase init hosting re-prompts for source #8617

Conversation

aalej commented May 16, 2025 • edited Loading

Description

Scenarios Tested

14.2.2 behavior

branch behavior

Sample Commands

jamesdaniels May 16, 2025

Choose a reason for hiding this comment

jamesdaniels May 16, 2025

Choose a reason for hiding this comment

aalej May 16, 2025

Choose a reason for hiding this comment

aalej commented May 16, 2025 •

edited

Loading